Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http_cache of issue 1246 #1368

Closed
wants to merge 4 commits into from
Closed

Fix http_cache of issue 1246 #1368

wants to merge 4 commits into from

Conversation

joeherold
Copy link

@joeherold joeherold commented Feb 13, 2018

@leofeyer
@Toflar

This pull-request should fix the issue, with the not working http_cache.

Tested in my local environment and works like a charm.

The implementation also preserves the ability, to cache inserttags individually and do not cache insert tags with the pipe uncached or refresh.

This should fix the problem from issue http_cache not working #1246
(#1246)

A new event listener (FinalCacheHeadersListener) is restoring the cache headers.

bildschirmfoto 2018-02-13 um 15 11 16

@leofeyer
Copy link
Member

This is basically the same approach as #1283, which we have decided against.

@joeherold
Copy link
Author

@leofeyer great, @Toflar asked me to do so...
#1246 (comment)

Yeah we might need to do so. But also I would like to make this dependent on the global $objPage, so essentially moving the FrontendTemplate::setCacheHeaders() into that listener. Would you like to work on a Pull Request for the Core-Bundle for that? That would be awesome

@leofeyer
Copy link
Member

@joeherold We have a core developer's meeting next week and this topic is on our agenda. Is it ok if we delay this discussion until after the meeting?

@joeherold
Copy link
Author

Sure. To not have stress I made the 3rd Party Bundle as a quick fix workaround. https://packagist.org/packages/pliigo/pagecacheenabler-bundle.

So anyone needs it now, can help himself by installing it via manager.

I just made it, because yannick asked to. feel free to discuss.

@Toflar
Copy link
Member

Toflar commented Feb 13, 2018

I didn't know about the solution in #1283 (which indeed is the same), sorry. It's impossible to keep track of all the stuff that's going on :S

@joeherold
Copy link
Author

@Toflar Auf den Kaffee od. Bier freue ich mich dennoch :)

@leofeyer
Copy link
Member

See #1388 now.

@leofeyer leofeyer closed this Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants