-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Twig 3.10.2 the minimum requirement #7214
Conversation
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change, rest LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a test testContaoUsesCorrectTwigFunctionSignatures
that checks for the function signatures of the library functions. We now call the runtimes, but we still test the signature of the global functions. IMHO we should either change that or drop the test.
Dropped in 6dea4c8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
This pull request makes Twig 3.10.2 the minimum version and therefore does not need all the BC layers.
@contao/developers Do we want to add this to Contao 5.3 or only in Contao 5.4?