Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the cookie headers in the isSessionEmpty() method #7213

Merged
merged 3 commits into from
May 23, 2024
Merged

Check the cookie headers in the isSessionEmpty() method #7213

merged 3 commits into from
May 23, 2024

Conversation

ausi
Copy link
Member

@ausi ausi commented May 13, 2024

Attempt to fix #7167

@ausi ausi added the bug label May 13, 2024
@ausi ausi added this to the 4.13 milestone May 13, 2024
@ausi ausi requested a review from fritzmg May 13, 2024 21:48
@ausi ausi self-assigned this May 13, 2024
@ausi ausi mentioned this pull request May 13, 2024
Closed
@fritzmg
Copy link
Contributor

fritzmg commented May 14, 2024

What about ContaoCsrfTokenManager::isSessionEmpty() - do we need to incorporate it there too?

fritzmg
fritzmg approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise verified that this fixes #7167

@ausi
Copy link
Member Author

ausi commented May 14, 2024

What about ContaoCsrfTokenManager::isSessionEmpty() - do we need to incorporate it there too?

I don’t think so, as there only the request is in question (and not the response).

@fritzmg fritzmg mentioned this pull request May 18, 2024
Open
@leofeyer leofeyer linked an issue May 21, 2024 that may be closed by this pull request
Invalid request token error when sending invalid form again #7167
Closed
@leofeyer leofeyer changed the title Check cookie headers for empty session check Check cookie headers in the isSessionEmpty() method May 23, 2024
@leofeyer leofeyer changed the title Check cookie headers in the isSessionEmpty() method Check the cookie headers in the isSessionEmpty() method May 23, 2024
@leofeyer leofeyer merged commit ae5da03 into contao:4.13 May 23, 2024
17 of 18 checks passed
@leofeyer
Copy link
Member

Thank you @ausi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzmg fritzmg fritzmg approved these changes

Assignees

@ausi ausi

Labels
bug
Projects
None yet
Milestone
4.13
Development

Successfully merging this pull request may close these issues.

Invalid request token error when sending invalid form again
3 participants
@ausi @fritzmg @leofeyer