Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have multiple problems to solve in 5.3+:
|insert_tag
will currently usereplaceInline()
. This means,{{date::whatever}}
will never work reliably as it never uses a fragment at the moment.inline
fragments to affect the cache settings. Meaning you can create anInsertTagResult
withgetExpiresAt()
or cache tags but it will never affect anything unless you specifiedasFragment: true
. We should probably always use theinline
renderer ifasFragment
is set tofalse
(which would require all insert tags to be registered as fragments though, otherwise ourFragmentHandler
won't care).pageId
and also therequest
which will cause a cache entry for every single page even though they are - in case of{{date::Y}}
- completely irrelevant.Imho we should not pass on any request parameters. I know this would be kind of a BC break but on the other hand, it's also a bugfix. If you want a fragment insert tag, you should make sure, the insert tag contains all of its information needed to render. So instead of dynamically resolving some format based on the page ID, the format should be part of the insert tag.
But not sure here as currently the implementation by @ausi assumes, insert tag instances are immutable.
This is just a quick hack here to simplify discussion.
Related: #7178