Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the PhpdocTypesOrderFixer again #4395

Merged
merged 3 commits into from Mar 28, 2022
Merged

Enable the PhpdocTypesOrderFixer again #4395

merged 3 commits into from Mar 28, 2022

Conversation

driftingly
Copy link
Contributor

This can be enabled now that PHP-CS-Fixer/PHP-CS-Fixer#6243 has been merged.

Originally added here.

I originally created PR #4392 but couldn't seem to switch the base branch.

@m-vo
Copy link
Member

m-vo commented Mar 26, 2022

I originally created PR #4392 but couldn't seem to switch the base branch.

You can do this by clicking Edit near the title and then picking a branch from the select menu.

@driftingly
Copy link
Contributor Author

When I did that the PR ended up having like 520 commits and a couple conflicts 🤷

@m-vo
Copy link
Member

m-vo commented Mar 26, 2022

When I did that the PR ended up having like 520 commits and a couple conflicts shrug

That is expected as you based your commits onto the wrong branch then. To fix, you need to rebase your local branch.

E.g. run git rebase <old-target-branch> --onto=<new-target-branch> and then force push.

@driftingly
Copy link
Contributor Author

Ah, thanks!

@ausi ausi added the CI label Mar 26, 2022
@ausi ausi added this to the 4.13 milestone Mar 26, 2022
@m-vo
Copy link
Member

m-vo commented Mar 26, 2022

The PHP-CS-Fixer version needs to be bumped to 3.6.0 as well. Currently it's a transitive dependency of ECS, so we either need to add it to make it a hard one or update to a version of ECS that requires it as well before this can be merged.

@ausi
Copy link
Member

ausi commented Mar 26, 2022

Updated ecs in 05cc6c6

@leofeyer leofeyer changed the title Enable PhpdocTypesOrderFixer Enable the PhpdocTypesOrderFixer again Mar 28, 2022
@leofeyer leofeyer merged commit 7e31869 into contao:4.13 Mar 28, 2022
@leofeyer
Copy link
Member

Thank you @driftingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants