Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add oci image index support #1533

Merged
merged 1 commit into from
Jan 22, 2023
Merged

feat: add oci image index support #1533

merged 1 commit into from
Jan 22, 2023

Conversation

piksel
Copy link
Member

@piksel piksel commented Jan 22, 2023

This PR simply appends application/vnd.oci.image.index.v1+json to the Accepted header when querying for image manifests. This format was added to docker buildx v0.10 and for images that use it, causes watchtower 1.5.1 to fail checking for changes using HEAD requests (since the repository returns a 404 when the Accepted mime type is not present for the manifest).

When testing locally, watchtower was able to get the digests for all the found problematic images.

Fixes #1528.

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Base: 66.19% // Head: 66.20% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (42be14b) compared to base (c16ac96).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1533      +/-   ##
==========================================
+ Coverage   66.19%   66.20%   +0.01%     
==========================================
  Files          24       24              
  Lines        2313     2314       +1     
==========================================
+ Hits         1531     1532       +1     
  Misses        682      682              
  Partials      100      100              
Impacted Files Coverage Δ
pkg/registry/digest/digest.go 43.52% <100.00%> (+0.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@piksel piksel changed the title feat: add oci image index support feat: add oci image index support Jan 22, 2023
@piksel piksel merged commit 14b235a into main Jan 22, 2023
@piksel piksel deleted the feat/digest-oci-index branch January 22, 2023 08:59
tigerinus added a commit to IceWhaleTech/CasaOS-AppManagement that referenced this pull request Jan 29, 2023
port from containrrr/watchtower#1533

Signed-off-by: Tiger Wang <tigerwang@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Could not do a head request for
1 participant