build: Bump github.com/docker/go-units to 0.5.0 #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to improve performance by not using regular expressions [1].
However, the potential reduction in binary size is lost because Toolbx
already uses the 'regexp' package to check if a string might be the ID
of an image or a valid container name.
[1] go-units commit 737572633c434ce2
docker/go-units@737572633c434ce2
docker/go-units#40
containers#1420
debarshiray
force-pushed
the
wip/rishi/src-go-mod-docker-go-units-0.5
branch
from
015f7d5
to
3dea936
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 8m 29s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to improve performance by not using regular expressions [1]. However, the potential reduction in binary size is lost because Toolbx already uses the 'regexp' package to check if a string might be the ID of an image or a valid container name.
[1] go-units commit 737572633c434ce2
docker/go-units@737572633c434ce2
docker/go-units#40