Make the unit tests work for FreeBSD #1360
Merged
+47
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
rhatdan
approved these changes
Sep 26, 2022
This avoids code having to cast the value returned by Mkdev and coding in assuptions on the type of Mknod's dev argument. Signed-off-by: Doug Rabson <dfr@rabson.org>
flouthoc
reviewed
Sep 27, 2022
On FreeBSD, the link syscall follows symlinks which makes TestUntarHardlinkToSymlink fail. We can match the expected semantics on FreeBSD using linkat. Signed-off-by: Doug Rabson <dfr@rabson.org>
This fixes a failure in TestApplyLayer caused by different modes on the symlinks in the test due to the test setup using a different umask from ApplyLayer. FreeBSD actually has an lchmod syscall and supports changing the mode on symlinks so we can use that. Signed-off-by: Doug Rabson <dfr@rabson.org>
Signed-off-by: Doug Rabson <dfr@rabson.org>
These are testing things like /etc/os-release and cgroups which are linux-only. Note: /etc/os-release does exist on FreeBSD but GetOperatingSystem is implemented using uname. Signed-off-by: Doug Rabson <dfr@rabson.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposed a couple of FreeBSD bugs in pkg/archive which are also fixed here.