Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail on walking os of EOPNOTSUPP for Llistxatt #1323

Merged
merged 1 commit into from Sep 7, 2022
Merged

Don't fail on walking os of EOPNOTSUPP for Llistxatt #1323

merged 1 commit into from Sep 7, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 6, 2022 •
edited

Fixes: #1321

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@rhatdan
Copy link
Member Author

rhatdan commented Sep 6, 2022

@nalind @giuseppe @vrothberg @saschagrunert @TomSweeneyRedHat @flouthoc PTAL

@rhatdan
Don't fail on walking os of EOPNOTSUPP for Llistxatt
03698d4 
Fixes: containers#1321

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@nalind
Copy link
Member

nalind commented Sep 6, 2022

LGTM. I was thinking it would be faster to let us break out of WalkDir() on the first failure, but we probably do need to continue scanning at least the top-level directory.
Non-blocking: we should just merge check_116.go in with the regular check.go, since we dropped the 1.15-and-earlier implementation in #1176.

flouthoc
flouthoc approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vrothberg
vrothberg approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 5aff7f6 into containers:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@flouthoc flouthoc flouthoc approved these changes

@vrothberg vrothberg vrothberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Llistxattr fails on merged proc file system
5 participants
@rhatdan @nalind @saschagrunert @flouthoc @vrothberg