Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chown: use overflow id as fallback when chowning #1220

Merged
merged 3 commits into from Apr 28, 2022
Merged

chown: use overflow id as fallback when chowning #1220

merged 3 commits into from Apr 28, 2022

Commits on Apr 28, 2022

  1. graphtest: use unique names for the file system layers 

    Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
    @giuseppe
    giuseppe committed Apr 28, 2022
    Copy the full SHA
    e2dae5e View commit details
    Browse the repository at this point in the history

  2. idtools: add new function to fallback to overflow id 

    add a new function ToHostOverflow() that instead of raising an error
when the mapping is not possible in the target user namespace, fall
back to using the overflow ID.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
    @giuseppe
    giuseppe committed Apr 28, 2022
    Copy the full SHA
    ed447c3 View commit details
    Browse the repository at this point in the history

  3. chown: use ToHostOverflow when chowning 

    when chowning an image, fall back to the overflow ID when a UID or GID
cannot be mapped to the target user namespace.

This ensures the chown driver works similar to what we do with
idmapped mounts when it is supported for overlay.

It is needed for CRI-O to support user namespaces in Kubernetes since
the Kubelet picks a static size for the user namespace and it might
break some images using IDs outside the picked range.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
    @giuseppe
    giuseppe committed Apr 28, 2022
    Copy the full SHA
    28c166f View commit details
    Browse the repository at this point in the history