layerStore.Put(): update digest-based indexes when creating from templates #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mistakenly mixed up the uncompressed and compressed digests when populating the by-uncompressed-digest map. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
…lates When we're creating a layer using another layer as a template, add the new layer's uncompressed and compressed digest to the maps we use to index layers using those digests. When we forgot to do that, searching for a layer by either would still turn up the original template, so this didn't really break anything. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
vrothberg
reviewed
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're creating a layer using another layer as a template, add the new layer's uncompressed and compressed digest to the maps we use to index layers using those digests.
When we forgot to do that, searching for a layer by either would still turn up the original template, so this didn't really break anything.
We also had a case in layerStore.PutAdditionalLayer() where we mistakenly mixed up the uncompressed and compressed digests when populating the by-uncompressed-digest map; fix that while we're in here.