Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Alternative to 1148): Don't blindly reuse state from a previous layer when re-creating it #1140

Merged
merged 1 commit into from May 2, 2022

Commits on Apr 22, 2022

  1. Don't blindly reuse state from a previous layer when re-creating it

    We have reports in the wild of a layer store where two symbolic links
    in linkDir point to the same layer. That could only happen when calling
    Driver.create with a previously-used layer ID (which happens all the time
    because pulls use deterministic layer IDs), without fully deleting
    the previous version of the layer (so far, we don't know how that has
    happened).
    
    To avoid such situations, don't just leave whatever was in
    the layer directory laying around; try to remove any pre-existing
    contents, as well as the symbolic link in linkDir, if any.
    
    Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    mtrmac committed Apr 22, 2022
    Copy the full SHA
    2a3194c View commit details
    Browse the repository at this point in the history