Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] store: Make additionalimagestores configurable as layerstore source #20604

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/system/010-images.bats
Expand Up @@ -344,7 +344,7 @@ Deleted: $pauseID"
driver="overlay"

[storage.options]
additionalimagestores = [ "$imstore/root" ]
additionalimagestores = [ "$imstore/root|NO_REUSE" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can invent an infinite number of new options. Please don’t add ambiguous in-line syntaxes unless there is really no other alternative.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this is just merely a compact version to collect feedback. There should be more agreeable manners to achieve it.

EOF

skopeo copy containers-storage:$IMAGE \
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions vendor/github.com/containers/storage/store.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.