Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow volume mount dups, iff source and dest dirs #16165

Merged
merged 1 commit into from Oct 17, 2022
Merged

Allow volume mount dups, iff source and dest dirs #16165

merged 1 commit into from Oct 17, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 13, 2022

Fixes: #4217

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

Does this PR introduce a user-facing change?

Duplicate volume mounts as long as source and destination match are now allowed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@edsantiago
Copy link
Collaborator

Tests LGTM. PR title (and commit message) seems incomplete?

@edsantiago
Copy link
Collaborator

Ewwww.

Failed fetch: read ${CIRRUS_DEFAULT_WORK}\.git\HEAD: The process cannot access the file 
     because another process has locked a portion of the file.!

@mheon
Copy link
Member

mheon commented Oct 13, 2022

What about identical source/dest but different options? I think that's why we did string dedup/exact match detection in the API

@rhatdan
Copy link
Member Author

rhatdan commented Oct 15, 2022

@mheon I believe I have handled the options issue now.

@rhatdan
Allow volume mount dups, iff source and dest dirs
75222ad 
Also create one constant for ErrDuplicateDest, rather then have the same
value set three times.

Fixes: containers#4217

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@baude
Copy link
Member

baude commented Oct 16, 2022

LGTM

@mheon
Copy link
Member

mheon commented Oct 17, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit e7d6b68 into containers:main Oct 17, 2022
@edsantiago edsantiago mentioned this pull request Oct 24, 2022
Closed
@rhatdan rhatdan deleted the dups branch December 1, 2022 22:00
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman rejects duplicate mount specifications
5 participants
@rhatdan @edsantiago @mheon @baude @openshift-merge-robot