Ignore cpu realtime options on cgroups V2 systems #15713
Merged
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstosh
force-pushed
the
cpu-rt-cgroupsv2
branch
from
50dfc8c
to
db23027
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, sstosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I think you have a typo in your commit message, the first sentence should say: |
`--cpu-rt-period` and `--cpu-rt-runtime` options are only supported on cgroups V1 rootful systems. Therefore, podman prints an warning message and ignores these options when we use cgroups V2 systems. Related to: containers#15666 Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
sstosh
force-pushed
the
cpu-rt-cgroupsv2
branch
from
db23027
to
c7411af
Compare
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--cpu-rt-periodand--cpu-rt-runtimeoptions are only supported on cgroups V1 rootless systems.Therefore, podman prints an warning message and ignores these options when we use cgroups V2 systems.
Related to: #15666
Signed-off-by: Toshiki Sonoda sonoda.toshiki@fujitsu.com
Does this PR introduce a user-facing change?