Add generate systemd -e/--env option

[sstosh]

-e/--env option sets environment variables to the systemd unit files.

Fixes: #15523

Signed-off-by: Toshiki Sonoda sonoda.toshiki@fujitsu.com

Does this PR introduce a user-facing change?

Now we can use -e/--env option to sets environment variables to the systemd unit files.

[vrothberg]

LGTM
@containers/podman-maintainers PTAL

[Luap99]

Please also add some new unit tests here:

podman/pkg/systemd/generate/containers_test.go

Line 42 in 098c071

func TestCreateContainerSystemdUnit(t *testing.T) {

to make sure you get exactly what you expect.

[vrothberg]

LGTM
@Luap99 PTAL

[Luap99]

Sorry one thing I missed yesterday was that you have to escape the arguments if required, see

podman/pkg/systemd/generate/containers.go

Line 487 in 43baf49

info.ExtraEnvs = append(info.ExtraEnvs, escapeSystemdArg(containerEnv))

and

podman/pkg/systemd/generate/containers_test.go

Line 764 in 43baf49

Environment=FOO=abc "BAR=my test" USER=%%a

When the env var contains a space or a special character such as % the systemd unit would likely fail right now.

[rhatdan]

@Luap99 PTAL again.

[Luap99]

LGTM, thanks

[Luap99]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, sstosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment