Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman kube play/down --read from URL #15426

Merged
merged 1 commit into from Aug 23, 2022
Merged

podman kube play/down --read from URL #15426

merged 1 commit into from Aug 23, 2022

Conversation

nicrowe00
Copy link
Collaborator

@nicrowe00 nicrowe00 commented Aug 23, 2022

podman kube play can create pods and containers from YAML
read from a URL poiniting to a YAML file.
For example: podman kube play https://example.com/demo.yml.
podman kube down can also teardown pods and containers created
from that YAML file by also reading YAML from a URL, provided the
YAML file the URL points to has not been changed or altered since
it was used to create pods and containers

Closes #14955
Signed-off-by: Niall Crowe nicrowe@redhat.com

Does this PR introduce a user-facing change?

`podman kube play` can create pods and containers by reading YAML from a URL.
`podman kube down` can teardown pods and containers by reading YAML from a URL,
provided the YAML file the URL points to has not been changed or altered since the creation
of the pods and containers that need to be removed.

@nicrowe00
Copy link
Collaborator Author

@vrothberg PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Just some small nits.

cmd/podman/kube/play.go Outdated Show resolved Hide resolved
docs/source/markdown/podman-kube-down.1.md Outdated Show resolved Hide resolved
docs/source/markdown/podman-kube-play.1.md.in Show resolved Hide resolved
pkg/domain/entities/play.go Outdated Show resolved Hide resolved
cmd/podman/kube/down.go Outdated Show resolved Hide resolved
`podman kube play` can create pods and containers from YAML
read from a URL poiniting to a YAML file.
For example: `podman kube play https://example.com/demo.yml`.
`podman kube down` can also teardown pods and containers created
from that YAML file by also reading YAML from a URL, provided the
YAML file the URL points to has not been changed or altered since
it was used to create pods and containers

Closes #14955
Signed-off-by: Niall Crowe <nicrowe@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented Aug 23, 2022

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@umohnani8
Copy link
Member

LGTM
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nicrowe00, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5dea121 into containers:main Aug 23, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] kube play $URL
5 participants