Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendor of containers/buildah and friends #13479

Closed
wants to merge 1 commit into from
Closed

Update vendor of containers/buildah and friends #13479

wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 10, 2022

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@mheon
Copy link
Member

mheon commented Mar 10, 2022

Tests are red, otherwise LGTM

flouthoc
flouthoc approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

Changes LGTM, if you can smooth out the test redness.

@flouthoc
Copy link
Collaborator

flouthoc commented Mar 11, 2022 •
edited

@rhatdan Test is failing because version 5.20 was cut before this was merged containers/image#1480 , so release 5.20 is missing this PR and hence it reverts back to racy c/image.

I think we must release a new c/image before it can be vendor-ed into podman or buildah.

@vrothberg
Copy link
Member

vrothberg commented Mar 11, 2022 •
edited

I think we must release a new c/image before it can be vendor-ed into podman or buildah.

No need for a release. Just go get github.com/containers/image/v5@$desiredCommit.

I prefer to only cut releases for the libraries when we need to release the tools.

@rhatdan
Update vendor of containers/buildah and friends
67a64d2 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
vrothberg
vrothberg reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flouthoc
flouthoc reviewed Mar 12, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it seems new diff for https://github.com/containers/podman/blob/main/test/buildah-bud/buildah-tests.diff needs to be generated.

@rhatdan
Copy link
Member Author

rhatdan commented Mar 13, 2022

@flouthoc Since I am on PTO this week, do you want to take this one over?

@flouthoc
Copy link
Collaborator

Sure. I'll take over this.

@flouthoc
Copy link
Collaborator

@rhatdan Please feel free to close this PR i'll open a new one to vendor everything into podman.

@rhatdan rhatdan closed this Mar 14, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flouthoc flouthoc flouthoc approved these changes

@vrothberg vrothberg vrothberg left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rhatdan @mheon @TomSweeneyRedHat @flouthoc @vrothberg