Skip to content

Commit

Permalink
[CI:DOCS] Installer: use latest wix in windows installer
Browse files Browse the repository at this point in the history
Replace choco with dotnet for wix installation as choco doesn't have
anything newer than v3.14.
Ref: https://community.chocolatey.org/packages/wixtoolset

Use wildcard in place of wix version in contrib/win-installer/build.ps1.
Ref: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_wildcards?view=powershell-7.4

Resolves: RUN-2055

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
  • Loading branch information
lsm5 committed Apr 18, 2024
1 parent 01d0f88 commit 6fd23b0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/upload-win-installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ jobs:
- name: Dry Run Status
run: |
Write-Output "::notice::This workflow execution will be a dry-run: ${{ steps.actual_dryrun.outputs.dryrun }}"
- name: Install Wix
run: dotnet tool install --global wix
- name: Determine version
id: getversion
run: |
Expand Down
5 changes: 3 additions & 2 deletions contrib/win-installer/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,12 @@ function CheckCommand() {

function CheckRequirements() {
CheckCommand "gcc" "MingW CC"
# Install latest wix
dotnet tool install --global wix
CheckCommand "candle" "WiX Toolset"
CheckCommand "go" "Golang"
}


if ($args.Count -lt 1 -or $args[0].Length -lt 1) {
Write-Host "Usage: " $MyInvocation.MyCommand.Name "<version> [dev|prod] [release_dir]"
Write-Host
Expand All @@ -99,7 +100,7 @@ if ($args.Count -lt 1 -or $args[0].Length -lt 1) {
}

# Pre-set to standard locations in-case build env does not refresh paths
$Env:Path="$Env:Path;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64\bin;;C:\Program Files\Go\bin"
$Env:Path="$Env:Path;C:\Program Files (x86)\WiX Toolset *\bin;C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64\bin;;C:\Program Files\Go\bin"

CheckRequirements

Expand Down

0 comments on commit 6fd23b0

Please sign in to comment.