Add documentation for PKCS #11 with IBM CEX #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jakob-Naucke Great! I had used the IBM CEX for experiments previously and it helped shape the code to what it is now. I am currently away but I'll have a look at your write-up once I am back. Thanks! |
lumjjb
reviewed
Aug 23, 2021
There was a problem hiding this comment.
Awesome - thanks @Jakob-Naucke , made a couple suggested nits. And in addition, suggested adding a line to just spell out that this is not an endorsement of any particular choice.
|
added a paragraph separator |
|
@stefanberger do you have a chance to look at this? Am good from my side, but this is your area of specialty, so will defer to you. |
stefanberger
requested changes
Sep 16, 2021
|
Ah, I had forgotten about this PR. Apart from that one change I requested it looks good to me. |
Documentation for backing OCIcrypt with PKCS #11 and SoftHSM2 is already available. It is also possible to do this with an IBM CryptoExpress HSM, but there are some specifics to know. Add documentation for this. Signed-off-by: Jakob Naucke <jakob.naucke@ibm.com> Co-authored-by: Brandon Lum <lumjjb@gmail.com>
stefanberger
approved these changes
Sep 17, 2021
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for backing OCIcrypt with PKCS #11 and SoftHSM2 is already
available. It is also possible to do this with an IBM CryptoExpress HSM,
but there are some specifics to know. Add documentation for this.
Signed-off-by: Jakob Naucke jakob.naucke@ibm.com