WIP: Only obtain a bearer token once at a time #1968
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
commented
May 29, 2023
mtrmac
force-pushed
the
shared-token
branch
4 times, most recently
from
84d61b4
to
e2c713b
Compare
We will want to manage concurrency in more detail. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... to reduce repetitiveness, and allow updating them in a single place. Should not change (test) behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Inline assertBearerTokensEqual . Use testify instead of manual t.Fatalf. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We will want to add locks and more to the in-memory type; sharing that with JSON gets awkward, and an explicit separation between the externally-imposed structure and internal records is cleaner anyway. For now, just introduces a separate type with the same structure, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
No need to make it a public field now. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
That's the value that really matters, not the inputs; and we will remove the inputs from bearerToken. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
These fields need to exist when parsing JSON; but we can just record the outcome of processing them. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... because we will make it more complex. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... to decrease indentation and remove a variable. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We will want to add a lock to it, so we must stop copying it by value. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Instead of having getBearerToken* construct a new bearerToken object, have the caller provide one. This will allow us to record that a token is being obtained, so that others can wait for it. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Only moves unchanged code, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Currently, on pushes, we can start several concurrent layer pushes; each one will check for a bearer token in tokenCache, find none, and ask the server for one, and then write it into the cache. So, we can hammer the server with 6 basically-concurrent token requests. That's unnecessary, slower than just asking once, and potentially might impact rate limiting heuristics. Instead, serialize writes to a bearerToken so that we only have one request in flight at a time. This does not apply to pulls, where the first request is for a manifest; that obtains a token, so subsequent concurrent layer pulls will not request a token again. WIP: Clean up the debugging log entries. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on pushes, we can start several concurrent layer pushes; each one will check for a bearer token in
tokenCache, find none, and ask the server for one, and then write it into the cache.So, we can hammer the server with 6 basically-concurrent token requests. That's unnecessary, slower than just asking once, and potentially might impact rate limiting heuristics.
Instead, serialize writes to a bearerToken so that we only have one request in flight at a time.
This does not apply to pulls, where the first request is for a manifest, which obtains a token, so subsequent concurrent layer pulls will not request a token again.
WIP: Clean up the debugging log entries.