Fulcio signing implementation #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
fulcio-signing
branch
from
6eafaba
to
b3ae511
Compare
|
Rebased, ready for review. |
|
Oops, still one path to try. |
... to be also used by Fulcio. Note that the atomic: transport uses a skopeo/... user agent, we don't care to change that. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Tested manually with Skopeo. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This seems, at best, useful for debugging and as an escape hatch for other missing OIDC operations. FIXME: test this at least once manually. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
fulcio-signing
branch
from
b87e89d
to
cd6511f
Compare
|
I have (manually) tested the “static ID token” path now. Ready for review and potentially merging now. |
This was referenced Jan 11, 2023
|
(Adding unit tests tracked in #1601.) |
|
LGTM |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds API to use Fulcio-generated short-lived certificates.
Depends on #1784 .
I still need to test one part but it seems broadly ready.
I don’t feel too confident about the API, but it seems close enough, and we can always add more option functions, or a new
signature/sigstore/fulciov2package (still operating onsignature/sigstore/internal.Signer)