OCI-archive multi-manifest support POC #1677
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reader/writer with helpers to allow podman save/load multi oci-archive images.
Allow read oci-archive using source_index to point to the index from oci-archive manifest.
Also reimplement ociArchiveImage{Source,Destination} to support this.
Signed-off-by: Qi Wang <qiwan@redhat.com>
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
…nto multi-manifest-poc Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
It's unclear what it was intended for, and right now it results in awkwardly worded error messages. Assuming this exists just to minimize duplication in error text, just duplicate (the fixed version) of that error text. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Don't get a layout reference we are not going to use. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Eliminate an unnecessary "d" variable. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
to be more similar to docker/internal/tarfile.Reader.ChooseManifestItem: - Move non-error paths to the non-indented main flow - Prefer situations with image specified to the no-data default Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... and explicitly handle an impossible situation Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We are going to use it in LoadManifestDescriptorWithContext. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…rchive.Reader ... and drop the now redundant untar code. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
added a commit
to mtrmac/common
that referenced
this pull request
Oct 6, 2022
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This was referenced Oct 6, 2022
|
See #1381 (comment) . |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1381 updated to merge on top of current main, + an attempt to resolve review comments, only to have something to try in c/common.