[release-5.19 backport] Remove keyring support and Cirrus update to f36 VMs #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsm5
changed the title
The package is not used, noone is currently working on wiring it up, and it started failing in CI (apparently because it assumes the user's keyring is empty when tests start, which is now not reliably the case). Instead of fixing the tests, just remove it; we can always restore the code from Git history. Signed-off-by: Miloslav Trmač <mitr@redhat.com> (cherry picked from commit 576c8db) Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
force-pushed
the
release-5.19-keyring-backport
branch
from
03cd809
to
8e7401f
Compare
|
i think this is best clubbed in with #1540 in a single PR. |
Signed-off-by: Chris Evich <cevich@redhat.com> (cherry picked from commit 90eec84) Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
|
@mtrmac PTAL. |
lsm5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package is not used, noone is currently working on wiring it up,
and it started failing in CI (apparently because it assumes the user's
keyring is empty when tests start, which is now not reliably the case).
Instead of fixing the tests, just remove it; we can always restore
the code from Git history.
Signed-off-by: Miloslav Trmač mitr@redhat.com
(cherry picked from commit 576c8db)
Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org
@mtrmac PTAL