man containers-registries.conf: clarify mirror association #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtrmac PTAL |
|
LGTM |
mtrmac
reviewed
Apr 21, 2022
| location = "registry.com" | ||
|
|
||
| [[registry.mirror]] | ||
| location = "mirror.registry.com" | ||
| ``` | ||
| Given the above, a pull of `example.com/foo/image:latest` will try: | ||
| 1. `example-mirror-0.local/mirror-for-foo/image:latest` |
There was a problem hiding this comment.
Not part of this change, but it looks like there's an extra leading space on this line.
There was a problem hiding this comment.
Hum… the md2man output is an indented list of lines of some sort (https://github.com/russross/blackfriday/blob/e96880f42b9343aea6cbfd99693adae0e5fe2b2a/block.go#L81-L92 it seems). The GitHub markdown does not treat it as a list at all, and just folds the line into the preceding paragraph.
There was a problem hiding this comment.
Let’s fix that: #1527 (after this PR).
|
@mtrmac @TomSweeneyRedHat PTAL |
Clarify that a `[[registry.mirror]]` is associated only with the previous `[[registry]]`. Fixes: containers#1523 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that a
[[registry.mirror]]is associated only with theprevious
[[registry]].Fixes: #1523
Signed-off-by: Valentin Rothberg vrothberg@redhat.com