Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formally require Go 1.15 #1493

Merged
merged 6 commits into from Mar 19, 2022
Merged

Formally require Go 1.15 #1493

merged 6 commits into from Mar 19, 2022

Commits on Mar 17, 2022

  1. Update an obsolete comment 

    Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Mar 17, 2022
    Copy the full SHA
    d2ea8f1 View commit details
    Browse the repository at this point in the history

  2. Use Testing.T.Cleanup() to simplify tests 

    Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Mar 17, 2022
    Copy the full SHA
    f0d818b View commit details
    Browse the repository at this point in the history

  3. Modify makeRequestToResolvedURL and makeRequestToResolvedURLOnce to a… 

    …ccept an *url.URL

This is, sadly, wasteful, because NewRequestWithContext() only accepts
a string and parses it again, but it gives us more type safety, and simplifies
at least some callers.

Most importantly, this will also allow us to call url.Redacted() for logging.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Mar 17, 2022
    Copy the full SHA
    fa54b28 View commit details
    Browse the repository at this point in the history

  4. Use url.Redacted() in log output 

    ... to be at least a bit protected against credentials in logs.

I did try to find all uses, but it's possible I have missed some.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Mar 17, 2022
    Copy the full SHA
    5a4b8a4 View commit details
    Browse the repository at this point in the history

  5. Use testing.T.TempDir() 

    ... to simplify tests.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Mar 17, 2022
    Copy the full SHA
    9a99049 View commit details
    Browse the repository at this point in the history

  6. Simplify blobifocache/internal/test.GenericCache 

    We no longer need a cleanup callback.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Mar 17, 2022
    Copy the full SHA
    a310b13 View commit details
    Browse the repository at this point in the history