Update docker resolver with support for redirects #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioluz
force-pushed
the
redirects
branch
3 times, most recently
from
959902b
to
8ec8ac6
Compare
Authorizes the request in case the host is redirected, supporting at most 10 redirects. Inspired in the containerd's implementation for supporting redirects. containerd/containerd@b1d4140 Signed-off-by: Fabio Luz <fabio.luz@scarf.sh>
vrothberg
reviewed
May 27, 2021
There was a problem hiding this comment.
LGTM, thank you!
@mtrmac PTAL
Initial issue: containerd/containerd#5503
|
Just a note for now: This needs careful review/research, compare #645 (comment) . |
|
Is there any update on this? Let me know if you need any changes. |
|
@mtrmac PTAL |
|
@mtrmac what is going on with this PR? |
|
I am also wondering when this could be merged. AFAIK, all the other container registry clients handle redirects these days. |
mtrmac
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authorizes the request in case the host is redirected, supporting at most 10 redirects.
Inspired in the containerd's implementation for supporting redirects. containerd/containerd@b1d4140
Signed-off-by: Fabio Luz fabio.luz@scarf.sh