FIXME FIXME: Add FIXMEs

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
containers · Jun 15, 2022 · dc9eca0 · dc9eca0
1 parent db2c360
commit dc9eca0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/copy/compression.go b/copy/compression.go
@@ -66,6 +66,7 @@ func (ic *imageCopier) blobPipelineCompressionStep(stream *sourceStream, canModi
 	// WARNING: If you are adding new reasons to change the blob, update also the OptimizeDestinationImageAlreadyExists
 	// short-circuit conditions
 	layerCompressionChangeSupported := ic.src.CanChangeLayerCompression(stream.info.MediaType)
+	// FIXME: More debug logs about this decision?
 	canChangeCompression := canModifyBlob && layerCompressionChangeSupported
 	if canChangeCompression {
 		for _, fn := range []func(*sourceStream, bpDetectCompressionStepData) (*bpCompressionStepData, error){

diff --git a/copy/copy.go b/copy/copy.go
@@ -687,6 +687,7 @@ func (c *copier) copyOneImage(ctx context.Context, policyContext *signature.Poli
 	//   that the compressed version coming from a third party may be designed to attack some other decompressor implementation,
 	//   and we would reuse and sign it.
 	// - Finally, let the image format handler influence this (in particular to disable substitution for OCI artifacts).
+	// FIXME: More debug logs about this decision?
 	ic.canSubstituteBlobs = ic.cannotModifyManifestReason == "" && options.SignBy == "" && ic.src.CanSubstituteLayers()
 
 	if err := ic.updateEmbeddedDockerReference(); err != nil {