Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't require DiffID computation when encryption is involved
AFAICS encryption doesn't _actually_ need diffIDs, at least I can't see any encryption-related use of the computed value; the boolean seems to only be set to avoid reuse (which risks unwanted reuse of plaintext data, or revealing relationships between ciphertext/plaintext to network observers). So, use two extra variables to be clear about the logic of the code. (Also reorder one condition to check a local variable first before calling methods, a microoptimizaion.) Should not change outcome of the operation (but the time and CPU usage no longer spent to unnecessarily compute DiffID values might be noticeable). Signed-off-by: Miloslav Trmač <mitr@redhat.com>
- Loading branch information