Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add spec and capabilities to sandbox run #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Add spec and capabilities to sandbox run #128

wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This adds the runtime spec creation as well as the capability handling to the sandbox run method.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added release-note-none kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 8, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #128 (bfcae2d) into master (56acde4) will increase coverage by 0.75%.
The diff coverage is 92.42%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   42.48%   43.24%   +0.75%     
==========================================
  Files          47       47              
  Lines        5359     5425      +66     
==========================================
+ Hits         2277     2346      +69     
+ Misses       3082     3079       -3     

Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like a good step but we should add it for a different InfraContainerSandbox. We don't need the spec for the PinnedSandbox :) I have a WIP for PinnedSandbox I will push tomorrow.

@saschagrunert
Copy link
Member Author

saschagrunert commented Oct 9, 2020

This PR looks like a good step but we should add it for a different InfraContainerSandbox. We don't need the spec for the PinnedSandbox :) I have a WIP for PinnedSandbox I will push tomorrow.

Ah okay, that's interesting. Now I'm wondering how we could apply capabilities without a spec 😇
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2020
@saschagrunert saschagrunert changed the title Add spec and capabilities to sandbox run WIP: Add spec and capabilities to sandbox run Oct 12, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 12, 2020
@openshift-ci-robot
Copy link

@saschagrunert: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants