Makefile: fix seccomp notify compilation issues #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Peter Hunt <pehunt@redhat.com>
|
fixes #275 |
|
LGTM |
giuseppe
reviewed
Jun 24, 2021
Makefile
Outdated
| endif | ||
|
|
||
| ifeq ($(shell $(PKG_CONFIG) --atleast-version 2.5.0 libseccomp && echo "0" || echo "1"), 0) | ||
| ifeq ($(shell $(PKG_CONFIG) --atleast-version 2.5.0 libseccomp && grep -rq "seccomp_notif_sizes" /usr/include && echo "0"), 0) |
There was a problem hiding this comment.
this could be expensive, and detect the string in other unrelated header files.
What do you think about replacing it with printf "#include <linux/seccomp.h>\nvoid main(){struct seccomp_notif_sizes s;}" | cc -x c - -o /dev/null ?
There was a problem hiding this comment.
updated as suggested!
haircommander
force-pushed
the
seccomp-notify-make-fix
branch
from
f1c02f7
to
147ac35
Compare
Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
seccomp-notify-make-fix
branch
from
147ac35
to
1d67d9e
Compare
Signed-off-by: Peter Hunt <pehunt@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on older kernels we need to also check if the proper headers are installed, in addition to the seccomp version
also, unify the syntax of conditional compilation variables