Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] TMT: revdep podman build test #1892

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .fmf/version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1
14 changes: 14 additions & 0 deletions .packit.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
jobs:
# All tests specified in the `/plans/` subdir
- job: tests
trigger: pull_request
#notifications:
#failure_comment:
# message: "podman build test failed. @containers/packit-build please check."
targets:
- fedora-rawhide-x86_64
- fedora-rawhide-aarch64
skip_build: true
enable_net: true
identifier: podman_build
tmt_plan: "/contrib/tmtplans/podman_build_test"
Binary file added contrib/tmtplans/.main.fmf.swp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsie

Binary file not shown.
24 changes: 24 additions & 0 deletions contrib/tmtplans/buildah_build_test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#!/usr/bin/env bash

set -eox pipefail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set -eox pipefail
set -exo pipefail

The order here is important.


rpm -q golang

if [ -f /etc/fedora-release ]; then
export TMPDIR=/var/tmp
fi
Comment on lines +7 to +9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the conditional? In all test environments I've seen, /var/tmp is much bigger than /tmp. It seems safest just to universally set TMPDIR=/var/tmp.


git clone https://github.com/containers/podman
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is named buildah_build_test but there's no buildah anything anywhere?

Now I understand the script names. Suggestion: rename both to "build_XXX" instead of XXX_build? "buildah_build_test," to me, suggests that you are testing buildah's build command.


cd podman
dnf -y builddep rpm/podman.spec

go mod edit -replace github.com/containers/common=../
make vendor
cat go.mod

git add vendor/
git config --global user.email "you@example.com"
git config --global user.name "Your Name"

make rpm
12 changes: 12 additions & 0 deletions contrib/tmtplans/main.fmf
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
prepare:
- how: install
package:
- git-core
- golang
- rpmdevtools

/podman_build_test:
summary: Build Podman
execute:
how: tmt
script: bash ./contrib/tmtplans/podman_build_test.sh
26 changes: 26 additions & 0 deletions contrib/tmtplans/podman_build_test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
#!/usr/bin/env bash

set -exo pipefail

rpm -q golang

#if [ -f /etc/fedora-release ]; then
# export TMPDIR=/var/tmp
#fi

# Navigate to parent dir of default working dir
cd ..

# Clone podman
git clone https://github.com/containers/podman

cd podman
dnf -y builddep rpm/podman.spec

# Vendor c/common from PR
# TMT_TREE points to the default working dir
go mod edit -replace github.com/containers/common=$TMT_TREE
make vendor
cat go.mod

make