Add kube_generate_type to set default for kube generate #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhatdan @vrothberg PTAL |
Luap99
reviewed
Apr 3, 2023
The kube_generate_type field can be used to set what kind of k8s object, i.e pod or deployment, that the podman kube generate command should generate by default. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vrothberg
reviewed
Apr 4, 2023
| @@ -540,6 +540,10 @@ reserving the pod's resources for the lifetime of the pod. By default container | |||
| engines run a built-in container using the pause executable. If you want override | |||
| specify an image to pull. | |||
|
|
|||
| **kube_generate_type**="pod" | |||
|
|
|||
| Default Kubernetes kind/specification of the kubernetes yaml generated with the `podman kube generate` command. The possible options are `pod` and `deployment`. | |||
There was a problem hiding this comment.
Shouldn't we point to man podman-kube-play for supported options?
We don't validate/parse the input here, so there's a risk of the docs getting out of date over time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kube_generate_type field can be used to set what kind of k8s object, i.e pod or deployment, that the podman kube generate command should generate by default.