Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Renovate #1384

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Configure Renovate #1384

merged 1 commit into from
Mar 31, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 28, 2023

Mend Renovate

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.


Detected Package Files

  • .github/workflows/validate.yml (github-actions)
  • go.mod (gomod)
  • .cirrus.yml (regex)

Configuration

🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.

Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.

What to Expect

With your current configuration, Renovate will create 11 Pull Requests:

fix(deps): update module github.com/opencontainers/runc to v1.1.5 [security]
[skip-ci] Update actions/checkout digest to 8f4b7f8
  • Schedule: ["at any time"]
  • Branch name: renovate/actions-checkout-digest
  • Merge into: main
  • Upgrade actions/checkout to 8f4b7f84864484a7bf31766abe9204da3cbe65b3
[skip-ci] Update actions/setup-go digest to 6edd440
  • Schedule: ["at any time"]
  • Branch name: renovate/actions-setup-go-digest
  • Merge into: main
  • Upgrade actions/setup-go to 6edd4406fa81c3da01a34fa6f6343087c207a568
[skip-ci] Update golangci/golangci-lint-action digest to 08e2f20
  • Schedule: ["at any time"]
  • Branch name: renovate/golangci-golangci-lint-action-digest
  • Merge into: main
  • Upgrade golangci/golangci-lint-action to 08e2f20817b15149a52b5b3ebe7de50aff2ba8c5
fix(deps): update github.com/containers/storage digest to 1da746e
  • Schedule: ["after 1am and before 11am on the first day of the month"]
  • Branch name: renovate/github.com-containers-storage-digest
  • Merge into: main
  • Upgrade github.com/containers/storage to 1da746e63eed5fd3b78a998e0f82485acd3745fd
fix(deps): update github.com/opencontainers/image-spec digest to dd7fd71
  • Schedule: ["after 1am and before 11am on the first day of the month"]
  • Branch name: renovate/github.com-opencontainers-image-spec-digest
  • Merge into: main
  • Upgrade github.com/opencontainers/image-spec to dd7fd714f5406d39db5fd0602a0e6090929dc85e
fix(deps): update github.com/opencontainers/runtime-tools digest to e931285
  • Schedule: ["after 1am and before 11am on the first day of the month"]
  • Branch name: renovate/github.com-opencontainers-runtime-tools-digest
  • Merge into: main
  • Upgrade github.com/opencontainers/runtime-tools to e931285f4b699ed577fca8327cbb3c51954aac2a
chore(deps): update module github.com/opencontainers/runc to v1.1.5
  • Schedule: ["at any time"]
  • Branch name: renovate/github.com-opencontainers-runc-1.x
  • Merge into: main
  • Upgrade github.com/opencontainers/runc to f19387a6bec4944c770f7668ab51c4348d9c2f38
fix(deps): update module github.com/onsi/gomega to v1.27.6
  • Schedule: ["at any time"]
  • Branch name: renovate/github.com-onsi-gomega-1.x
  • Merge into: main
  • Upgrade github.com/onsi/gomega to v1.27.6
[skip-ci] Update actions/setup-go action to v4
  • Schedule: ["at any time"]
  • Branch name: renovate/actions-setup-go-4.x
  • Merge into: main
  • Upgrade actions/setup-go to 4d34df0c2316fe8122ab82dc22947d607c0c91f9
chore(deps): update dependency containers/automation_images to v20230330
  • Schedule: ["at any time"]
  • Branch name: renovate/major-ci-vm-image
  • Merge into: main
  • Upgrade containers/automation_images to 20230330t153101z-f37f36d12

🚸 Branch creation will be limited to maximum 1 per hour, so it doesn't swamp any CI resources or overwhelm the project. See docs for prhourlylimit for details.


❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.


This PR has been generated by Mend Renovate. View repository job log here.

@cevich cevich self-assigned this Mar 28, 2023
@cevich
Copy link
Member

cevich commented Mar 28, 2023

Note: There was no maintainer team for this repo, so Renovate has been configured to assign PRs to the top 3 contributors: @rhatdan, @vrothberg, and @Luap99. If using a team is preferred, I can set one up.

@Luap99
Copy link
Member

Luap99 commented Mar 29, 2023

One blocker:

docs/Containerfile.5.md (dockerfile)

This is a man page and should not be updated.


Note: There was no maintainer team for this repo, so Renovate has been configured to assign PRs to the top 3 contributors: @rhatdan, @vrothberg, and @Luap99. If using a team is preferred, I can set one up.

Fine for me but where exactly is this configured?

@cevich
Copy link
Member

cevich commented Mar 29, 2023

This is a man page and should not be updated.

Uh-oh, I saw that and thought I pushed a setting to ignore it. I'll take another look.

Fine for me but where exactly is this configured?

It's configured in the org-level settings. I can do it, just not sure it makes sense for 3 people.

@cevich
Copy link
Member

cevich commented Mar 29, 2023

force-push: Restored customized config. Not sure why renovate-bot overwrote it.

@cevich
Copy link
Member

cevich commented Mar 29, 2023

force-push: tweaked docs ignoring pattern.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Copy link
Member

cevich commented Mar 29, 2023

force-push: Ignoring docs via packageRules wasn't working. Switched to an ignorePaths addition.

@cevich
Copy link
Member

cevich commented Mar 29, 2023

There we go, now it's ignoring docs/Containerfile.5.md (and all other documentation files) properly.

@Luap99
Copy link
Member

Luap99 commented Mar 29, 2023

Now I have something else to complain about:

Does this repo support [skip-ci]?

[skip-ci] Update golangci/golangci-lint-action digest to 08e2f20

The linter updates should never ever skip CI, it will often cause new warnings that must be fixed before merging.

@cevich
Copy link
Member

cevich commented Mar 29, 2023

Does this repo support [skip-ci]?

This is a magic keyword supported by Cirrus-CI. The renovate config. is setup to add it for updates to github-actions only. I don't believe github-actions supports this keyword, so the linter workflow should still run, only the Cirrus tasks would be bypassed.

Does that answer your question?

@Luap99
Copy link
Member

Luap99 commented Mar 29, 2023

Does this repo support [skip-ci]?

This is a magic keyword supported by Cirrus-CI. The renovate config. is setup to add it for updates to github-actions only. I don't believe github-actions supports this keyword, so the linter workflow should still run, only the Cirrus tasks would be bypassed.

Does that answer your question?

OK understood, if the lint job is still executed then this should be good.

LGTM

@Luap99
Copy link
Member

Luap99 commented Mar 31, 2023

Renovate really likes to overwrite your changes @cevich :/

@cevich
Copy link
Member

cevich commented Mar 31, 2023

Ya, it seems every 24h on every renovate PR I have open. I have no idea how to prevent it 😞

@Luap99
Copy link
Member

Luap99 commented Mar 31, 2023

Ya, it seems every 24h on every renovate PR I have open. I have no idea how to prevent it

Ping people to merge it before that. You have my LGTM just need someone else to merge it.
@vrothberg @rhatdan

@rhatdan
Copy link
Member

rhatdan commented Mar 31, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: renovate[bot], rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ddf389e into main Mar 31, 2023
2 checks passed
@renovate renovate bot deleted the renovate/configure branch April 5, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants