Integration tests: fake up a replacement for nixery.dev/shell #5495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
nalind
force-pushed
the
replace-nixery-dev-shell
branch
from
c231e8d
to
e2cd877
Compare
nalind
force-pushed
the
replace-nixery-dev-shell
branch
from
e2cd877
to
a0dbe6f
Compare
nalind
force-pushed
the
replace-nixery-dev-shell
branch
2 times, most recently
from
e7f4d4c
to
faa852d
Compare
|
LGTM |
nalind
force-pushed
the
replace-nixery-dev-shell
branch
7 times, most recently
from
fca4fd1
to
413ffb6
Compare
nalind
force-pushed
the
replace-nixery-dev-shell
branch
3 times, most recently
from
f67f427
to
3fb60f0
Compare
|
LGTM |
|
I still think this is unmaintainable and will cause someone a big headache in the future. I won't block it, but I can't be the one to merge it either. |
Build a fake layers-but-no-history image that should work more or less as well for the tests that we were previously using nixery.dev/shell for. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
When we get a tried-to-write-to-closed-pipe error while encoding something for a coprocess, try to capture error output from the coprocess and add it to the error message, to hopefully catch a flake we're seeing in CI. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
replace-nixery-dev-shell
branch
from
3fb60f0
to
7953c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Build a fake layers-but-no-history image that should work more or less as well for the tests that we were previously using nixery.dev/shell for.
How to verify it
Updated integration test!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?