integration test: handle new labels in "bud and test --unsetlabel" #5487
Conversation
openshift-ci
bot
added
the
kind/failing-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/lgtm |
Instead of assuming which labels are set in our base image, and using the --unsetlabel flag to suppress them in a derived image, query the base image and unset all of them, except for our own version label. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
fedora-minimal-name
branch
from
ad3686a
to
c01061e
Compare
|
LGTM |
|
/cherry-pick release-1.35 |
|
@nalind: new pull request created: #5503 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.33 |
|
@nalind: new pull request created: #5504 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.34 |
|
@nalind: new pull request created: #5506 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Instead of assuming which labels are set in our base image, and using the
--unsetlabelflag to suppress them in a derived image, query the base image and unset all of them, except for our own version label. The newly-currentfedora-minimal:40has more labels set on it thanfedora-minimal:39did, and I don't want to have to revise this test again in six months.How to verify it
The "bud and test --unsetlabel" test should pass again.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?