Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release note template to split dependency chores #5463

Merged

Conversation

der-eismann
Copy link
Contributor

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design

/kind documentation

/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

This PR adds a template to the repository to use with auto-generated release notes from GitHub. In the release notes for https://github.com/containers/buildah/releases/tag/v1.35.0 everything is put in one list, which makes it hard to differentiate actual changes from dependency updates.
This template puts the dependency updates in a separate paragraph, causing the release notes to look cleaner. This only works when PRs are labelled correctly, which is the case for renovate, but #5184 for example would need the dependencies label.

How to verify it

Try to auto-generate release notes, but it only works after merging.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 8, 2024
@rhatdan
Copy link
Member

rhatdan commented Apr 8, 2024

Thanks @der-eismann
You need to sign your commit.
git commit --amend -s -a
git push --force

@der-eismann
Copy link
Contributor Author

Done, thanks for the reminder!

@rhatdan
Copy link
Member

rhatdan commented Apr 8, 2024

@TomSweeneyRedHat @mheon WDYT?

@mheon
Copy link
Member

mheon commented Apr 8, 2024

We manually split the release notes up in Podman, so automating at least part of the work seems good?

@TomSweeneyRedHat
Copy link
Member

Works for me, but needs a rebase. I've been spinning a mess load of releases as of late, and it's been notably messy at best.

Copy link

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented May 13, 2024

@der-eismann are you still working on this?

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@github-actions github-actions bot removed the stale-pr label May 14, 2024
@der-eismann
Copy link
Contributor Author

@der-eismann are you still working on this?

Yes, but I have no idea why builds fail on such a change.

Signed-off-by: Philipp Trulson <der-eismann@users.noreply.github.com>
@TomSweeneyRedHat
Copy link
Member

@der-eismann The build issues may be unrelated. We have been having some "fun" with our CI as of later.

@rhatdan
Copy link
Member

rhatdan commented May 16, 2024

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: der-eismann, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f83d266 into containers:main May 16, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/documentation Categorizes issue or PR as related to documentation. lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants