[skip-ci] Makefile: update rpm target #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsm5
force-pushed
the
makefile-rpm-update
branch
from
09af01f
to
1a519ac
Compare
lsm5
force-pushed
the
makefile-rpm-update
branch
from
1a519ac
to
279b1a1
Compare
|
@containers/buildah-maintainers PTAL |
|
LGTM |
rpkg is now deprecated. This commit makes the rpm target consistent with the one in Podman. Using skip-ci as we don't need to run cirrus tests for this change. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
lsm5
force-pushed
the
makefile-rpm-update
branch
from
279b1a1
to
e53e50f
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, lsm5, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpkg is now deprecated. This commit makes the rpm target consistent with the one in Podman.
Using skip-ci as we don't need to run cirrus tests for this change.
What type of PR is this?
/kind other
What this PR does / why we need it:
updates Makefile's rpm target
How to verify it
run
make rpmWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
This could be useful in reverse dependency tests in c/common
See: containers/common#1892
Does this PR introduce a user-facing change?