[release-1.28] Define and use a safe, reliable test image and bump to v1.28.2
#4433
Conversation
|
@edsantiago Could you please take a look |
There was a problem hiding this comment.
Patch LGTM, I diffed against main to make sure. One cleanup request.
Is this expected to be an active branch? If so, would it make sense to backport #4397 also, to get rid of other ubi-related risks?
@edsantiago Yes this is active branch. I will also backport #4397 to this PR. |
The ubi8 image changed some architecture string yesterday and broke all our CI on all branches, including podman because it too runs bud.bats tests. Solution: use a safe, reliable, trustworthy test image (the one built and used for podman). Because that image does not have the same labels, confirm pull using .Architecture instead. We should stop using ubi8 and registry.redhat (containers#4318). They are unreliable. This PR doesn't fix that; it's just an emergency patch for one specific CI break. We can use this as a basis for future removals of ubi8. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Aditya R <arajan@redhat.com>
First: because we have a bunch of tests that rely on the image manifest list, and ubi8 is not under our control: we've already seen where ubi8 gets changed without our knowledge, requiring almost a week of scrambling to get things fixed again. Second, the registry it lives on is unreliable. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
release-1.28
branch
2 times, most recently
from
0f5da31
to
a5e3bf3
Compare
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
release-1.28
branch
from
a5e3bf3
to
5fb010f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
I thought older
buildahandpodmanv4.3branch does not accounts forSAFEIMAGEhence I created a simpler retrofit commit here #4428 ( I was wrong ) and it looks like podman's old branch were already expecting #4377.A note from @edsantiago in podman's
v4.3branch containers/podman@52a6516 clearly mentions that #4377 had to be backported.Since I missed backporting it before so doing it now and cutting a release.
PR which will use this release: containers/podman#16588