Add test for prevention of reusing encrypted layers #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This test will succeed after containers/image#1533 is introduced. |
|
@hshiina Could you please rebase this , |
hshiina
force-pushed
the
test-not-reuse-encrypt-layer
branch
from
ec56c8e
to
5a9ba0c
Compare
This fix modifies the test "commit oci encrypt to registry" to verify that encrypted layers are not reused for a non-encrypted image. see: containers/image#1533 Signed-off-by: Hironori Shiina <shiina.hironori@jp.fujitsu.com>
hshiina
force-pushed
the
test-not-reuse-encrypt-layer
branch
from
5a9ba0c
to
063abf6
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hshiina, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hironori Shiina shiina.hironori@jp.fujitsu.com
What type of PR is this?
/kind other
What this PR does / why we need it:
This fix modifies the test "commit oci encrypt to registry" to verify that encrypted layers are not reused for a non-encrypted image. This test verifies a fix in containers/image#1533.
How to verify it
Run the modified test:
bats tests/commit.batsWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?