[release-1.23 backport] bump to race-free c/image and c/storage
#3903
Conversation
Signed-off-by: Aditya R <arajan@redhat.com>
Use race-free `AddNames` instead of `SetNames` by bumping `c/image` Signed-off-by: Aditya R <arajan@redhat.com>
|
@jnovy @TomSweeneyRedHat PTAL |
|
Smoke is failing cause |
| @@ -894,7 +894,7 @@ func setCapabilities(spec *specs.Spec, keepCaps ...string) error { | |||
| capMap := map[capability.CapType][]string{ | |||
| capability.BOUNDING: spec.Process.Capabilities.Bounding, | |||
| capability.EFFECTIVE: spec.Process.Capabilities.Effective, | |||
| capability.INHERITABLE: []string{}, | |||
| capability.INHERITABLE: {}, | |||
There was a problem hiding this comment.
This was added here #3853 , I am just running gofmt here so smoke test passes.
There was a problem hiding this comment.
An empty slice either way, so I don't see an issue with it.
There was a problem hiding this comment.
Strange that gofmt changed it though.
This is causing smoke test to fail so replace run.go with a goformatted version. [NO NEW TESTS NEEDED] Signed-off-by: Aditya R <arajan@redhat.com>
TomSweeneyRedHat
changed the title
c/image and c/storagec/image and c/storage
|
LGTM |
|
@containers/buildah-maintainers PTAL. Could we merge this and cut a new |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We would need a release as well or i could vendor branch directly as well if that works. |
|
@flouthoc, I'll spin one up shortly. Just getting out of morning meetings now. |
|
I just spun one up, but I did it by hand, will see if it fails. |
|
Thx @rhatdan ! |
A new version of buildah was released after containers/buildah#3903 which is using race-free deps so use that. Signed-off-by: Aditya R <arajan@redhat.com>
Commits explained in bullet points.
AddNamesinstead ofSetNamesimage#1519For reference actual upstream PR: containers/image#1480 and containers/storage#1153
Deps are tested here: containers/podman#13793
Needed for: BZ 2066364