Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never update golang toolchain #195

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Apr 29, 2024

Fixes: #193

Despite restrictions on go directive updates by Renovate, it was still proposing updates to the toolchain directive. In order to maintain consistency across all projects, this value needs to be managed manually. Detect when Renovate is trying to update it and shut it down.

Ref: Upstream https://github.com/renovatebot/renovate PR 28476

Fixes: containers#193

Despite restrictions on `go` directive updates by Renovate, it was still
proposing updates to the `toolchain` directive.  In order to maintain
consistency across all projects, this value needs to be managed
manually.  Detect when Renovate is trying to update it and shut it down.

Ref: Upstream https://github.com/renovatebot/renovate PR 28476

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich requested a review from Luap99 April 29, 2024 20:03
Copy link

github-actions bot commented Apr 29, 2024

Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's 2e805276bbe2076bd3a8063093354e30edd3bbb9.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cevich
Copy link
Member Author

cevich commented Apr 30, 2024

Crossing fingers...

@cevich cevich merged commit 9a8a1a2 into containers:main Apr 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

renovate: need to diable toolchain updates
2 participants