Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 support for AddDefaultRoute #802

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

Y7n05h
Copy link
Contributor

@Y7n05h Y7n05h commented Dec 28, 2022

AddDefaultRoute assumes that the user is adding a default route for IPv4, not IPv6. This pr will fix it.

Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
@mccv1r0
Copy link
Member

mccv1r0 commented Jan 3, 2023

Is there an issue with a description of something that isn't working? AFAICT this function isn't used.

A few other things...

  1. adding default isn't either/or it maybe (and probably is) both unless single stack IPv6 is used. If IPv4 is defined add 0.0.0.0/0. If IPv6 is used, add ::/0.

  2. The default route for IPv6 is (supposed to be) obtained via RA.

@Y7n05h
Copy link
Contributor Author

Y7n05h commented Jan 8, 2023

  1. The default route for IPv6 is (supposed to be) obtained via RA.

Usually the default route for IPv6 is automatically configured by Router Advertisements. But sometimes it is necessary to configure it manually.

  • Some routing devices do not send Router Advertisements
  • When there are multiple IPv6 devices, and the default route configured by Router Advertisements does not match the expected device

@mccv1r0
Copy link
Member

mccv1r0 commented Jan 9, 2023

  1. The default route for IPv6 is (supposed to be) obtained via RA.

Usually the default route for IPv6 is automatically configured by Router Advertisements. But sometimes it is necessary to configure it manually.

  • Some routing devices do not send Router Advertisements
  • When there are multiple IPv6 devices, and the default route configured by Router Advertisements does not match the expected device

@mccv1r0 mccv1r0 closed this Jan 9, 2023
@mccv1r0 mccv1r0 reopened this Jan 9, 2023
@mccv1r0
Copy link
Member

mccv1r0 commented Jan 9, 2023

Closed due to lack of coffee. Apologies

  1. The default route for IPv6 is (supposed to be) obtained via RA.

Usually the default route for IPv6 is automatically configured by Router Advertisements. But sometimes it is necessary to configure it manually.

  • Some routing devices do not send Router Advertisements

The (current) cloud world we live in sadly. The PR makes sense as a result. Is this for your plugin? IIRC this isn't used by any of the CNI reference plugins.

  • When there are multiple IPv6 devices, and the default route configured by Router Advertisements does not match the expected device

This I'm having a harder time parsing... "expected" device? If the network tells you what to use it's best to use that and not what you expected. I get 8 default routes from my ISP (cheapest plan), some come and go as ISP needs require. It's safe for me not to expect any.

@squeed
Copy link
Member

squeed commented Jan 9, 2023

Note: This function isn't used by the plugins, I can't guarantee it continues to exist.

@squeed squeed merged commit 87ccb89 into containernetworking:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants