Check for duplicated sysctl keys #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmirecki looks good! Can you fix DCO and go fmt? Then I can merge when CI goes green. |
mmirecki
force-pushed
the
tuning_duplicate_check
branch
from
c09a7df
to
72db601
Compare
squeed
reviewed
Apr 21, 2022
mmirecki
force-pushed
the
tuning_duplicate_check
branch
from
72db601
to
7accdeb
Compare
|
lgtm, will merge tomorrow |
mars1024
reviewed
Apr 27, 2022
mmirecki
force-pushed
the
tuning_duplicate_check
branch
from
7accdeb
to
50ca338
Compare
|
LGTM after the dupe check gets moved to parseConf() instead of just in cmdAdd(). |
Signed-off-by: mmirecki <mmirecki@redhat.com>
mmirecki
force-pushed
the
tuning_duplicate_check
branch
from
50ca338
to
7c452c7
Compare
|
/lgtm |
mccv1r0
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tuning-cni config currently allows to specif duplicated sysctls, also with conflicting values. Duplicated sysctl entries are usually not used intentionally, but are rather the result of an error in configuration.
This PR adds a check for duplicated sysctl's.