host-device: Add support for DPDK device #490

pperiyasamy · 2020-05-22T10:25:57Z

This commit would make host-device plugin as a placeholder
for DPDK device when applications wants to attach it with
a pod container through network attachment definition.

Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech

matthewdupre · 2020-05-27T15:48:53Z

Is there a reason you can't just use the noop plugin instead? (https://github.com/containernetworking/cni/tree/master/plugins/test/noop)

pperiyasamy · 2020-05-28T13:53:26Z

Is there a reason you can't just use the noop plugin instead?

@matthewdupre yes, we (@JanScheurich) were also looking for such "dummy" CNI plugin for this purpose. Thanks for pointing it out.

bboreham · 2020-06-03T15:27:39Z

@pperiyasamy should this PR be closed then?

JanScheurich · 2020-06-03T15:38:15Z

Actually, it would simplify life considerably if the host-device plugin could transparently handle the case that the PCI networking device is not bound to a kernel driver and just skip the actions tied to a kernel netdev (e.g. IPAM) in a similar way as the SRIOV CNI plugin on the host skips these actions if the SRIOV VF is not bound to a kernel driver. Then the user of Kubernetes wouldn’t have to worry about using a special CNI plugin for PCI device NADs in case of Intel VFs or virtio-net devices bound to igb_uio drivers, while in all other cases the host-device CNI is just fine.

plugins/main/host-device/host-device.go

bboreham · 2020-06-10T15:51:53Z

plugins/main/host-device/host-device.go

@@ -43,6 +43,8 @@ const (
 	sysBusPCI = "/sys/bus/pci/devices"
 )

+var userspaceDrivers = []string{"vfio-pci", "uio_pci_generic", "igb_uio"}


I'm a bit ignorant of DPDK; is there no more generic way to detect it than a hard-coded list of names?

AFAIK, this is the way to find the dpdk device as per the driver bound to it (https://doc.dpdk.org/guides/linux_gsg/linux_drivers.html)

squeed · 2020-06-10T15:52:56Z

plugins/main/host-device/host-device.go

+		if isDpdkMode {
+			result := current.Result{
+				CNIVersion: current.ImplementedSpecVersion,
+				Interfaces: []*current.Interface{


Arguably Interfaces should be empty; given that the interface doesn't exist...

ok, now handling the error returned from hasDpdkDriver method, hope that suffices.

Not exactly. AIUI, DPDK doesn't actually create an interface (that would show up in ip link), right? So, we shouldn't return it in Result. Instead, we should just return an empty result.

ah! yes, good find. now changed it to return empty result for dpdk device.

squeed · 2020-06-10T15:53:34Z

plugins/main/host-device/host-device.go

@@ -91,6 +93,23 @@ func cmdAdd(args *skel.CmdArgs) error {
 	}
 	defer containerNs.Close()

+	var result *current.Result


There's no need to add this here; you initialize a new result on line 100 with the :=

I've just moved this variable here from line no. 104 (in existing code), Now updated :=, thanks.

squeed · 2020-06-10T15:54:12Z

Also, please add a note to the plugin's README documenting this behavior.

pperiyasamy · 2020-06-12T14:29:49Z

Also, please add a note to the plugin's README documenting this behavior.

Yes, added now.

dcbw · 2020-08-26T15:55:01Z

/lgtm

pperiyasamy · 2020-09-29T09:57:38Z

@dcbw is this good to merge now ?

martinkennelly · 2020-11-18T17:21:28Z

@dcbw Any update on this patch? Thanks Dan.

This commit would make host-device plugin as a placeholder for DPDK device when applications wants to attach it with a pod container through network attachment definition. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

pperiyasamy · 2020-11-19T07:59:38Z

@martinkennelly Thanks for following it up, just rebased the PR to resolve conflicts for README.md. Let me raise another PR separately for README.md changes in cni.dev repo.

martinkennelly · 2020-12-21T11:41:40Z

CC @squeed @mccv1r0

adpempx · 2021-01-15T23:56:01Z

Guys,

could you please merge this MR?

This is mandatory use case for DPDK people with SRIOV environment in VMs.

Thanks

adpempx · 2021-01-17T09:27:35Z

Hi @bboreham,

thanks for you approval.
I also verified this change in my environment:

Intel X710 configured with SR-IOV in VM in ESXi
DPDK by using userspace driver: igb_uio

and everything works without any issue.

Could you please let us know when your amazing Team will merge this MR in master branch?
Are you planning a new release with this code change?

Thanks

prem-b · 2021-01-18T10:51:50Z

Hello Team,
Any plan, by when this shall be available?

Thanks

bboreham · 2021-01-18T11:58:53Z

I would like @squeed to take one more look since he had a lot of comments earlier.

jellonek · 2021-01-20T16:18:12Z

It would be nice to have at least test case which would describe such use type with explanation why in a particular case this plugin should work basically as a no-op.

pperiyasamy · 2021-01-21T08:48:33Z

Thanks for merging the fix. can you also merge its readme ?

lynic · 2021-01-29T02:24:03Z

Is there any plan to support IPAM for DPDK interface in host-device cni? like k8snetworkplumbingwg/sriov-cni#142

This commit would make host-device plugin as a placeholder for DPDK device when applications wants to attach it with a pod container through network attachment definition. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

squeed reviewed Jun 10, 2020

View reviewed changes

plugins/main/host-device/host-device.go Show resolved Hide resolved

bboreham reviewed Jun 10, 2020

View reviewed changes

squeed reviewed Jun 10, 2020

View reviewed changes

pperiyasamy force-pushed the dpdk branch from 4fa0fdb to 61c82cb Compare June 12, 2020 14:33

pperiyasamy added 3 commits November 19, 2020 08:42

Add support for DPDK device

39eee3d

This commit would make host-device plugin as a placeholder for DPDK device when applications wants to attach it with a pod container through network attachment definition. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

Fix the review comments

a4dbb7a

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

Return empty result for DPDK device

6fc0648

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

pperiyasamy force-pushed the dpdk branch from 8eaf226 to 6fc0648 Compare November 19, 2020 07:46

pperiyasamy mentioned this pull request Nov 20, 2020

update host-device readme for dpdk support containernetworking/cni.dev#66

Merged

adrianchiris mentioned this pull request Dec 3, 2020

Add support for VFs within a VM k8snetworkplumbingwg/sriov-cni#121

Closed

bboreham changed the title ~~Add support for DPDK device~~ host-device: Add support for DPDK device Jan 16, 2021

bboreham approved these changes Jan 16, 2021

View reviewed changes

jellonek approved these changes Jan 20, 2021

View reviewed changes

squeed merged commit d41acb8 into containernetworking:master Jan 20, 2021

lynic mentioned this pull request Jan 29, 2021

host-device: Support IPAM for DPDK device #578

Closed

dependabot bot mentioned this pull request Mar 18, 2021

Bump github.com/containernetworking/plugins from 0.9.0 to 0.9.1 RoyceDavison/firecracker-go-sdk#4

Open

dougbtv mentioned this pull request Aug 12, 2021

Bug 1989342: host-device: Add support for DPDK device openshift/containernetworking-plugins#51

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

host-device: Add support for DPDK device #490

host-device: Add support for DPDK device #490

pperiyasamy commented May 22, 2020

matthewdupre commented May 27, 2020

pperiyasamy commented May 28, 2020 •

edited

bboreham commented Jun 3, 2020

JanScheurich commented Jun 3, 2020 via email •

edited

bboreham Jun 10, 2020

pperiyasamy Jun 12, 2020

squeed Jun 10, 2020

pperiyasamy Jun 12, 2020

squeed Jun 17, 2020

pperiyasamy Jun 18, 2020

squeed Jun 10, 2020

pperiyasamy Jun 12, 2020

squeed commented Jun 10, 2020

pperiyasamy commented Jun 12, 2020

dcbw commented Aug 26, 2020

pperiyasamy commented Sep 29, 2020

martinkennelly commented Nov 18, 2020

pperiyasamy commented Nov 19, 2020

martinkennelly commented Dec 21, 2020

adpempx commented Jan 15, 2021

adpempx commented Jan 17, 2021 •

edited

prem-b commented Jan 18, 2021

bboreham commented Jan 18, 2021

jellonek commented Jan 20, 2021

pperiyasamy commented Jan 21, 2021

lynic commented Jan 29, 2021

host-device: Add support for DPDK device #490

host-device: Add support for DPDK device #490

Conversation

pperiyasamy commented May 22, 2020

matthewdupre commented May 27, 2020

pperiyasamy commented May 28, 2020 • edited

bboreham commented Jun 3, 2020

JanScheurich commented Jun 3, 2020 via email • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

squeed commented Jun 10, 2020

pperiyasamy commented Jun 12, 2020

dcbw commented Aug 26, 2020

pperiyasamy commented Sep 29, 2020

martinkennelly commented Nov 18, 2020

pperiyasamy commented Nov 19, 2020

martinkennelly commented Dec 21, 2020

adpempx commented Jan 15, 2021

adpempx commented Jan 17, 2021 • edited

prem-b commented Jan 18, 2021

bboreham commented Jan 18, 2021

jellonek commented Jan 20, 2021

pperiyasamy commented Jan 21, 2021

lynic commented Jan 29, 2021

pperiyasamy commented May 28, 2020 •

edited

JanScheurich commented Jun 3, 2020 via email •

edited

adpempx commented Jan 17, 2021 •

edited