-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cgroup: v2: do not set subtree_control for new cg #37
Conversation
Hit another issue I thought was due to some other changes I have in my working tree, guess it's not just that... |
f777fa4
to
c51cb4a
Compare
Ok this is good to go. |
/cc @jsturtevant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
A cgroup can either have delegations (`cgroup.subtree_control` is populated) OR it can have processes in it, but not both. So we need to make sure that we don't add any controllers to the new cgroup's `cgroup.subtree_control` BUT we should continue to do so for any parents that we create. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Fixed comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
A cgroup can either have delegations (
cgroup.subtree_control
is populated) OR it can have processes in it, but not both. So we need to make sure that we don't add any controllers to the new cgroup'scgroup.subtree_control
BUT we should continue to do so for any parents that we create.Fixes #35