Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the problem of snapshotter's toml configuration file not working #380

Merged
merged 5 commits into from
Feb 24, 2023
Merged

Fix the problem of snapshotter's toml configuration file not working #380

merged 5 commits into from
Feb 24, 2023

Commits on Feb 24, 2023

  1. config: remove default value of cmd arguments 

    Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
    @sctb512
    sctb512 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    d6a58fc View commit details
    Browse the repository at this point in the history

  2. config: add test for loaded configuration with parsed arguments 

    Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
    @sctb512
    sctb512 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    76a3a8b View commit details
    Browse the repository at this point in the history

  3. config: avoid to load log_to_stdout from toml file 

    Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
    @sctb512
    sctb512 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    c07eaa4 View commit details
    Browse the repository at this point in the history

  4. tests: remove log_to_stdout from toml file 

    Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
    @sctb512
    sctb512 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    0f47bf8 View commit details
    Browse the repository at this point in the history

  5. tests: modify TestNewFlags for flags without default value 

    Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
    @sctb512
    sctb512 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    04e48e6 View commit details
    Browse the repository at this point in the history