Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some /etc/ file permissions (see containerd#2684) #2984

Merged
merged 1 commit into from May 11, 2024

Conversation

apostasie
Copy link
Contributor

@AkihiroSuda @rafi-gh

This intend to fix #2684

From local testing with a 0077 umask:

apo@oliphant:~ $ sudo ./nerdctl run -ti --network host --rm debian ls -lA
-rw------- 1 root root 241 May 10 15:28 /etc/resolv.conf
apo@oliphant:~ $ sudo ./nerdctl-patch run -ti --network host --rm debian ls -lA /etc/resolv.conf
-rw-r--r-- 1 root root 241 May 10 15:28 /etc/resolv.conf

The patch is very simple, and just chmod all three files after writing.

Let me know if this is acceptable in this state or if a more involved refactoring is in order.

@apostasie
Copy link
Contributor Author

CI is happy.
PTAL.

Thanks!

@AkihiroSuda
Copy link
Member

The commit looks good, but it's title should be more descriptive

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Copy link
Contributor Author

Fixed. Let me know if this is better.

Thank you @AkihiroSuda

@apostasie
Copy link
Contributor Author

apostasie commented May 11, 2024

Not sure what the CI failure is about.
Previous run was fine.
Is this flaky in any way? Or did I actually mess something here?

@AkihiroSuda AkihiroSuda changed the title Fix #2684 Fix some /etc/ file permissions (see containerd#2684) May 11, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit ec9d9ca into containerd:main May 11, 2024
22 checks passed
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants