New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD: CNI plugins #2429
base: main
Are you sure you want to change the base?
FreeBSD: CNI plugins #2429
Conversation
Depends on: samuelkarp/runj#46 |
7ae4ecb
to
208fb83
Compare
re: CI failures. |
Does this work? (With installing vbox to CI) |
443bd6d
to
55a8b65
Compare
CI failing
https://github.com/containerd/nerdctl/actions/runs/6077164574/job/16486397831?pr=2429 |
Yes, I am trying to repro it locally. Looks like there's no internet connection within the container :) |
be5647b
to
6cd21f3
Compare
} | ||
} | ||
} | ||
EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe nerdctl should create this automatically to simplify the setup process
EOF | ||
|
||
service pf onestart | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this config to docs too?
6cd21f3
to
23348db
Compare
23348db
to
70267b6
Compare
pkg/ocihook/ocihook_nonfreebsd.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be ocihook_linux.go
, as the code is specific to Linux
70267b6
to
e663e69
Compare
FreeBSD has the CNI plugins ported: https://www.freshports.org/net/containernetworking-plugins/. This allows us to enable CNI networking for FreeBSD containers. This change adapts the existing linux codebase to work on freebsd: - containerutil: use nullfs instead of bind mounts for resolv.conf, etc. - ocihook: freebsd's bridge plugin uses jail names in contrast to linux's network namespace usages - container creation: configure runj runtime to create vnet jails by default Signed-off-by: Artem Khramov <akhramov@pm.me>
FreeBSD has the CNI plugins ported:
https://www.freshports.org/net/containernetworking-plugins/. This allows us to enable CNI networking for FreeBSD containers.
This change adapts the existing linux codebase to work on freebsd: