Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config default network name for nerdctl #1150

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Jun 21, 2022

Fix #1128

Signed-off-by: Zheao.Li me@manjusaka.me

@Zheaoli Zheaoli marked this pull request as draft June 21, 2022 09:42
@Zheaoli Zheaoli force-pushed the manjusaka/support-default-network-name branch 3 times, most recently from 96429ea to 672fe48 Compare June 21, 2022 13:01
Signed-off-by: Zheao.Li <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/support-default-network-name branch from 672fe48 to 43de2b4 Compare June 21, 2022 13:22
@Zheaoli Zheaoli marked this pull request as ready for review June 21, 2022 15:26
@AkihiroSuda
Copy link
Member

Thanks, but I guess we should extend https://github.com/containerd/nerdctl/blob/master/docs/config.md to support specifying the default nerdctl run template and the nerdctl build template

#1154 (comment)

The format should be something like docker-compose.yaml (but s/yaml/toml/ probably)

@junnplus
Copy link
Member

junnplus commented Jul 9, 2022

Can we close this?

Follow up #1184

@Zheaoli Zheaoli closed this Jul 9, 2022
@Zheaoli Zheaoli deleted the manjusaka/support-default-network-name branch July 9, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants